Adding support for X-Dgraph-AuthToken header #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@elliotmassen can you sign the CLA? |
|
@MichelDiz Done :) |
MichelDiz
approved these changes
Feb 26, 2021
gja
approved these changes
Mar 4, 2021
|
@elliotmassen thanks for the PR. We'll see it live as soon we have a Ratel release. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue raised here (and originally in #224) by adding a new "Auth Token" setting to the "Extra Settings" tab in the server connection modal. The inputted value will then be sent as the
X-Dgraph-AuthTokenHTTP header on requests to the server.I'm not familar with the Ratel codebase, so it's possible that I've missed something! I've followed the same pattern used for the Slash API Key for consistency.
When I ran
./scripts/build.prod.shit made updates toyarn.lockandpackage-lock.json, however I presumed these changes should not be commited as this PR does not introduce any new depedencies.This change is
Ratel Preview: